This repository was archived by the owner on Sep 8, 2020. It is now read-only.
feat(sortable): allow extra element before/after ng-repeat #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes angular-ui#41, Fixed angular-ui#177, Fixed angular-ui#98 and Fixes angular-ui#207
|
👍 awesome PR @tepez 👍 How about targeting v0.14.x-dev for this PR? |
|
sure @thgreasi |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows to have extra elements before/after ng-repeat (only if they are not ng-repeat themselves).
See demonstration at: http://codepen.io/anon/pen/VYgOLv
It passes all the original tests. To test that it works with added items, I duplicated
sortable.e2e.spec.jsintosortable.e2e.extraElements.spec.jsand added a dummydivbefore and after theng-repeatin every test.Fixes #41, Fixed #177, Fixed #98 and Fixes #207